Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix apollo-cache-inmemory in IE11 #4012

Merged
merged 3 commits into from
Oct 24, 2018
Merged

Fix apollo-cache-inmemory in IE11 #4012

merged 3 commits into from
Oct 24, 2018

Conversation

ooflorent
Copy link
Contributor

@ooflorent ooflorent commented Oct 16, 2018 •
edited
Loading

In IE11, Map.prototype.set is not spec-compliant and returns undefined. This commit removes the chained calls on Map to avoid the TypeError.

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@apollo-cla
Copy link

@ooflorent: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

benjamn
benjamn requested changes Oct 16, 2018
View reviewed changes
Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, could we just fix the Map.prototype.set polyfill if it's broken in this file? Altering spec-compliant usage to avoid browser bugs should be a last resort, I think.

@ooflorent @benjamn
Fix apollo-cache-inmemory in IE11
39778af 
In IE11, Map.prototype.set is not spec-compliant and returns undefined.
This commit removes the chained calls on Map to avoid the TypeError.
benjamn added a commit to ooflorent/apollo-client that referenced this pull request Oct 24, 2018
@benjamn
Polyfill correct Map#set and Set#add return behavior.
3e2a00f 
Implementing my own suggestion:
apollographql#4012 (review)

This change would be sufficient to fix apollographql#4024, though apollographql#4012 helps as well.
@benjamn
Polyfill correct Map#set and Set#add return behavior.
61262b3 
Implementing my own suggestion:
apollographql#4012 (review)

This change would be sufficient to fix apollographql#4024, though apollographql#4012 helps as well.
@benjamn benjamn self-assigned this Oct 24, 2018
@benjamn benjamn merged commit 7fa0d85 into apollographql:master Oct 24, 2018
@alessbell alessbell mentioned this pull request Jun 24, 2022
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benjamn benjamn benjamn approved these changes

@bbrzoska bbrzoska bbrzoska approved these changes

Assignees

@benjamn benjamn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ooflorent @apollo-cla @benjamn @bbrzoska